Skip to content

feat: add column count to table tooltip#1382

Merged
dsmmcken merged 3 commits intomainfrom
dmckenzie_number_of_columns
Jun 21, 2023
Merged

feat: add column count to table tooltip#1382
dsmmcken merged 3 commits intomainfrom
dmckenzie_number_of_columns

Conversation

@dsmmcken
Copy link
Copy Markdown
Contributor

  • Adds the "Number of Columns" value to the tooltip.
  • Also converted to css-grid so things would line up nicely

dsmmcken added 3 commits June 20, 2023 16:38
- Adds the "Number of Columns" value to the tooltip.
- Also converted to css-grid so things would line up nicely
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 20, 2023

Codecov Report

Merging #1382 (f425a1b) into main (ed3a8c5) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1382      +/-   ##
==========================================
- Coverage   45.58%   45.58%   -0.01%     
==========================================
  Files         506      506              
  Lines       34966    34968       +2     
  Branches     8734     8735       +1     
==========================================
  Hits        15940    15940              
- Misses      18975    18977       +2     
  Partials       51       51              
Flag Coverage Δ
unit 45.58% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d-core-plugins/src/panels/IrisGridPanelTooltip.tsx 22.22% <0.00%> (-6.35%) ⬇️
...ard-core-plugins/src/panels/WidgetPanelTooltip.tsx 20.00% <0.00%> (ø)

@dsmmcken dsmmcken requested a review from mofojed June 20, 2023 21:04
@dsmmcken dsmmcken merged commit 004ac6c into main Jun 21, 2023
@dsmmcken dsmmcken deleted the dmckenzie_number_of_columns branch June 21, 2023 13:23
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants