fix: Remove unused ref forwarded to all dashboard panels#1451
Merged
mattrunyon merged 2 commits intodeephaven:mainfrom Aug 22, 2023
Merged
fix: Remove unused ref forwarded to all dashboard panels#1451mattrunyon merged 2 commits intodeephaven:mainfrom
mattrunyon merged 2 commits intodeephaven:mainfrom
Conversation
mofojed
approved these changes
Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ref doesn't seem to be used by anything and prints dev warnings if any panel is a functional component that doesn't use
React.forwardRef. I couldn't find anywhere we actually use the ref and it looks like it was a workaround for golden-layout adding the ref as default props to every component. The way we use golden-layout, I don't think it's even possible to attach a ref to the component in a way that a plugin could access that ref.