Skip to content

fix: Forbid @deephaven modules from self importing#1499

Merged
bmingles merged 2 commits intodeephaven:mainfrom
bmingles:1497-forbid-self-package-import-2
Sep 8, 2023
Merged

fix: Forbid @deephaven modules from self importing#1499
bmingles merged 2 commits intodeephaven:mainfrom
bmingles:1497-forbid-self-package-import-2

Conversation

@bmingles
Copy link
Copy Markdown
Contributor

@bmingles bmingles commented Sep 8, 2023

  • Eslint rules to forbid importing from @deephaven package owning the module
  • Fixed offending SessionUtils

I tested this by running npm run test:lint. It showed expected linting error before fixing SessionUtils. Fixing SessionUtils made error go away. Also tested in vscode. Error shows up in the editor as expected.

fixes #1497

@bmingles bmingles changed the title Forbid @deephaven modules from self importing fix: Forbid @deephaven modules from self importing Sep 8, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (d35aa49) 45.76% compared to head (e358402) 45.76%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1499      +/-   ##
==========================================
- Coverage   45.76%   45.76%   -0.01%     
==========================================
  Files         517      517              
  Lines       35162    35164       +2     
  Branches     8802     8804       +2     
==========================================
  Hits        16092    16092              
- Misses      19019    19021       +2     
  Partials       51       51              
Flag Coverage Δ
unit 45.76% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/jsapi-utils/src/SessionUtils.ts 2.63% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmingles bmingles merged commit 81cdd65 into deephaven:main Sep 8, 2023
@bmingles bmingles deleted the 1497-forbid-self-package-import-2 branch September 8, 2023 19:09
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SessionUtils has a self package import from @deephaven/jsapi-utils

2 participants