Skip to content

feat: Expose containerRef from ChartPanel#1500

Merged
mattrunyon merged 1 commit intodeephaven:mainfrom
mattrunyon:chart-panel-container-ref
Sep 8, 2023
Merged

feat: Expose containerRef from ChartPanel#1500
mattrunyon merged 1 commit intodeephaven:mainfrom
mattrunyon:chart-panel-container-ref

Conversation

@mattrunyon
Copy link
Copy Markdown
Collaborator

This is needed so the plotly-express plugin can attach event handlers to the chart container to pause re-renders when the user is manipulating the view on a 3d plot

@mattrunyon mattrunyon requested a review from mofojed September 8, 2023 19:46
@mattrunyon mattrunyon self-assigned this Sep 8, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8d890b7) 45.77% compared to head (ec7145a) 45.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1500   +/-   ##
=======================================
  Coverage   45.77%   45.77%           
=======================================
  Files         518      518           
  Lines       35177    35177           
  Branches     8812     8813    +1     
=======================================
  Hits        16103    16103           
  Misses      19023    19023           
  Partials       51       51           
Flag Coverage Δ
unit 45.77% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...s/dashboard-core-plugins/src/panels/ChartPanel.tsx 60.97% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattrunyon mattrunyon merged commit 848fef4 into deephaven:main Sep 8, 2023
@mattrunyon mattrunyon deleted the chart-panel-container-ref branch September 8, 2023 20:34
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants