feat: Update go to row panel's row number with cursorRow#1508
Merged
georgecwan merged 6 commits intodeephaven:mainfrom Sep 14, 2023
Merged
feat: Update go to row panel's row number with cursorRow#1508georgecwan merged 6 commits intodeephaven:mainfrom
georgecwan merged 6 commits intodeephaven:mainfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1508 +/- ##
==========================================
- Coverage 46.42% 46.42% -0.01%
==========================================
Files 558 558
Lines 35706 35719 +13
Branches 8917 8921 +4
==========================================
+ Hits 16576 16582 +6
- Misses 19080 19087 +7
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mofojed
requested changes
Sep 13, 2023
mofojed
requested changes
Sep 14, 2023
mofojed
approved these changes
Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The row number in the go to row panel now updates when users click on a row in the table. The value displayed when multiple selections or ranges of rows are selected depends on the value of cursorRow.
Fixes a bug where selecting a row then using the context menu to open the go to row panel would fill in the panel with the incorrect row number.
Resolves #1406.