Skip to content

fix: webpack dynamic import#1509

Merged
mofojed merged 3 commits intodeephaven:mainfrom
mofojed:fix-webpack-dynamic-import
Sep 12, 2023
Merged

fix: webpack dynamic import#1509
mofojed merged 3 commits intodeephaven:mainfrom
mofojed:fix-webpack-dynamic-import

Conversation

@mofojed
Copy link
Copy Markdown
Member

@mofojed mofojed commented Sep 12, 2023

@mofojed mofojed self-assigned this Sep 12, 2023
@mofojed mofojed marked this pull request as ready for review September 12, 2023 17:12
@mofojed mofojed requested a review from mattrunyon September 12, 2023 17:12
Copy link
Copy Markdown
Collaborator

@mattrunyon mattrunyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment that the webpack ignore comment is intentional so clients using webpack can consume ApiBootstrap. Don't want it to get accidentally removed since we don't use webpack

@mofojed mofojed requested a review from mattrunyon September 12, 2023 17:41
@mofojed mofojed enabled auto-merge (squash) September 12, 2023 17:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1283a34) 46.42% compared to head (2b76cce) 46.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1509   +/-   ##
=======================================
  Coverage   46.42%   46.42%           
=======================================
  Files         558      558           
  Lines       35691    35691           
  Branches     8915     8915           
=======================================
  Hits        16571    16571           
  Misses      19069    19069           
  Partials       51       51           
Flag Coverage Δ
unit 46.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed merged commit 1e8bb72 into deephaven:main Sep 12, 2023
@mofojed mofojed deleted the fix-webpack-dynamic-import branch September 12, 2023 17:55
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants