fix: Dehydration of class components#1535
Merged
mattrunyon merged 3 commits intodeephaven:mainfrom Sep 22, 2023
Merged
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1535 +/- ##
==========================================
- Coverage 46.42% 46.41% -0.01%
==========================================
Files 556 556
Lines 35711 35718 +7
Branches 8916 8923 +7
==========================================
Hits 16580 16580
- Misses 19081 19088 +7
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mofojed
approved these changes
Sep 22, 2023
Comment on lines
+137
to
+141
| const isClassComponent = | ||
| (isWrappedComponent(CType) && | ||
| CType.WrappedComponent.prototype != null && | ||
| CType.WrappedComponent.prototype.isReactComponent != null) || | ||
| (CType.prototype != null && CType.prototype.isReactComponent != null); |
mofojed
approved these changes
Sep 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1534