fix: Prompt for resetting layout#1552
Merged
bmingles merged 2 commits intodeephaven:mainfrom Sep 28, 2023
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1552 +/- ##
==========================================
- Coverage 46.41% 46.37% -0.04%
==========================================
Files 564 564
Lines 35765 35757 -8
Branches 8946 8952 +6
==========================================
- Hits 16599 16583 -16
- Misses 19116 19122 +6
- Partials 50 52 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
046279f to
ece22b4
Compare
mattrunyon
reviewed
Sep 28, 2023
Collaborator
mattrunyon
left a comment
There was a problem hiding this comment.
Code looks good. Want @dsmmcken to confirm the wording is what he wants
Contributor
Author
Don actually gave me the text. |
mattrunyon
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User is not prompted to confirm when using the "reset layout" feature.
fixes #1250