feat: Add support for multi-partition parquet:kv tables#1580
feat: Add support for multi-partition parquet:kv tables#1580georgecwan merged 7 commits intodeephaven:mainfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1580 +/- ##
==========================================
+ Coverage 46.65% 46.73% +0.08%
==========================================
Files 575 583 +8
Lines 36189 36324 +135
Branches 9063 9095 +32
==========================================
+ Hits 16883 16977 +94
- Misses 19254 19295 +41
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
5326170 to
ac3d366
Compare
…o 1438-multi-partition
ac3d366 to
c8b5b1f
Compare
mofojed
left a comment
There was a problem hiding this comment.
Need to worry about legacy format from dehydrated state, so update that type and handle it correctly in hydrateIrisGridPanelState.
9610545 to
a6d31a1
Compare
b0a89a9 to
9c9d099
Compare
mofojed
left a comment
There was a problem hiding this comment.
It looks good, but with the added hydration method and the imperative that we handle legacy data correctly, we need to add unit tests that cover those hydration cases.
0548e5d to
4875616
Compare
| 'hydrateIrisGridPanelStateV1 unselected partition', | ||
| { | ||
| isSelectingPartition: false, | ||
| partition: '', | ||
| partitionColumn: 'name_0', | ||
| advancedSettings: [], | ||
| }, | ||
| ], | ||
| [ | ||
| 'hydrateIrisGridPanelStateV1 one selected partition', | ||
| { | ||
| isSelectingPartition: true, | ||
| partition: '', | ||
| partitionColumn: 'name_0', | ||
| advancedSettings: [], | ||
| }, |
There was a problem hiding this comment.
These tests don't seem right. A selected partition should have a value for partition,. and the "unselected partition" test - are we testing the empty string? Or isSelectingPartition?
There was a problem hiding this comment.
I believe that the first test is testing for isSelectingPartition being false (in which case the value of partition) shouldn't matter and the second test is just testing for selecting a partition normally. partition should be null to signify a partition without a value so the second test is just testing for the empty string. I can use a non-empty string to make the test clearer.
| }); | ||
| }); | ||
|
|
||
| describe('hydration methods', () => { |
There was a problem hiding this comment.
Should have cases for no partition column as well.
a9b210f to
cfd3ff2
Compare
cfd3ff2 to
c80cd42
Compare
Added feature to
IrisGridPartitionSelectorto display additional partition selector dropdowns when more than one partition column is present. The values displayed in the dropdown depend on the selected partitions of columns to the left of it.The "Append Command" button and associated functions are removed in preparation for #1143.
Closes #1438
Testing instructions: