fix: Plugins were re-registering on every re-render#1613
Merged
mofojed merged 1 commit intodeephaven:mainfrom Nov 2, 2023
Merged
fix: Plugins were re-registering on every re-render#1613mofojed merged 1 commit intodeephaven:mainfrom
mofojed merged 1 commit intodeephaven:mainfrom
Conversation
- Forgot dependency array for `useEffect` hook
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1613 +/- ##
=======================================
Coverage 46.68% 46.68%
=======================================
Files 583 583
Lines 36267 36267
Branches 9074 9074
=======================================
Hits 16930 16930
Misses 19285 19285
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mattrunyon
approved these changes
Nov 2, 2023
Collaborator
mattrunyon
left a comment
mattrunyon
left a comment
There was a problem hiding this comment.
Didn't realize the linter doesn't catch the case where you accidentally omit the dependency array
Member
Author
Yea same. I don't know if this behaviour changed in React or in our linter? Without the dependency array, it re-runs every render. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useEffecthook