fix: Changes for Deephaven UI embedding widget plugins#1644
Merged
mattrunyon merged 7 commits intodeephaven:mainfrom Nov 20, 2023
Merged
fix: Changes for Deephaven UI embedding widget plugins#1644mattrunyon merged 7 commits intodeephaven:mainfrom
mattrunyon merged 7 commits intodeephaven:mainfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1644 +/- ##
==========================================
- Coverage 46.65% 46.57% -0.09%
==========================================
Files 593 597 +4
Lines 36467 36531 +64
Branches 9135 9142 +7
==========================================
Hits 17014 17014
- Misses 19401 19465 +64
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
requested changes
Nov 17, 2023
mofojed
approved these changes
Nov 17, 2023
mofojed
approved these changes
Nov 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are needed so Deephaven UI can embed widget plugins. This also creates a difference between the widget component and the widget panel component.
Will open a companion UI plugin PR to utilize these in Deephaven UI.
Tested the panels still function as intended for grid, chart, and dataframe.