Skip to content

fix: Made selector return types generic#1688

Merged
bmingles merged 2 commits intodeephaven:mainfrom
bmingles:1687-selector-types
Dec 12, 2023
Merged

fix: Made selector return types generic#1688
bmingles merged 2 commits intodeephaven:mainfrom
bmingles:1687-selector-types

Conversation

@bmingles
Copy link
Copy Markdown
Contributor

fixes #1687

@bmingles bmingles requested a review from mofojed December 12, 2023 15:13
* than `Required` because it will preserve optional properties on the original
* target type.
*/
export type UndoPartial<T> = T extends Partial<infer U> ? U : never;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh neat

@bmingles bmingles merged commit b2972f0 into deephaven:main Dec 12, 2023
@bmingles bmingles deleted the 1687-selector-types branch December 12, 2023 17:04
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redux selector return types should be generic

2 participants