feat: NavTabList component#1698
Merged
mattrunyon merged 9 commits intodeephaven:mainfrom Jan 4, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1698 +/- ##
==========================================
- Coverage 46.68% 46.45% -0.23%
==========================================
Files 609 611 +2
Lines 36985 37198 +213
Branches 9306 9357 +51
==========================================
+ Hits 17265 17279 +14
- Misses 19668 19865 +197
- Partials 52 54 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
requested changes
Dec 22, 2023
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Functionality looks good, context menu should be generated on click though
mattrunyon
force-pushed
the
dashboard-nav
branch
from
953f7fc to
ecd8a57
Compare
mofojed
previously approved these changes
Jan 2, 2024
dsmmcken
requested changes
Jan 3, 2024
Contributor
dsmmcken
left a comment
dsmmcken
left a comment
There was a problem hiding this comment.
Yes, that's the correct dh-color variable.
mofojed
approved these changes
Jan 4, 2024
dsmmcken
approved these changes
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is ported from DHE and generalized a bit so it can be used in DHC and DHE. Also cleaned up some of the CSS, but could still use some improvements for theming.
Test in the styleguide Navigations section. The 1st tab in both lists is non-closable. Add custom context actions for the styleguide which selects the tab to the left/right of the tab you opened the context menu on.