feat: Reject promise immediately if var not found#1718
Merged
wusteven815 merged 4 commits intodeephaven:mainfrom Jan 11, 2024
wusteven815:feat-1701
Merged
feat: Reject promise immediately if var not found#1718wusteven815 merged 4 commits intodeephaven:mainfrom wusteven815:feat-1701
wusteven815 merged 4 commits intodeephaven:mainfrom
wusteven815:feat-1701
Conversation
mofojed
requested changes
Jan 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1718 +/- ##
=======================================
Coverage 46.44% 46.44%
=======================================
Files 611 611
Lines 37204 37206 +2
Branches 9363 9364 +1
=======================================
+ Hits 17279 17281 +2
Misses 19871 19871
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
requested changes
Jan 9, 2024
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Looks good! Just a minor correction to the error message.
Co-authored-by: Mike Bender <mikebender@deephaven.io>
mofojed
approved these changes
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetchVariableDefinitionnow throws anErrorwhen a variable is not found (instead of throwingTimeoutError)TimeoutErrorstill used and will be thrown on an actual timeout