feat: DH-16336: usePickerWithSelectedValues - boolean flags should be calculated based on trimmed search text#1750
Merged
bmingles merged 4 commits intodeephaven:mainfrom Jan 31, 2024
Conversation
bmingles
commented
Jan 26, 2024
a1b2be7 to
7d26a76
Compare
7d26a76 to
ce652c2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1750 +/- ##
==========================================
+ Coverage 46.04% 46.07% +0.03%
==========================================
Files 621 623 +2
Lines 37454 37531 +77
Branches 9413 9437 +24
==========================================
+ Hits 17244 17293 +49
- Misses 20156 20184 +28
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
approved these changes
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports DH-16336:
isDebouncingprop touseDebouncedValueusePickerWithSelectedValuesresolves #1747
Note that there's not any place in DHC that uses the
usePickerWithSelectedValueshook yet. I've been testing locally as part of DH-16336.BREAKING CHANGE:
usePickerWithSelectedValuesnow takes an object as an argument instead of positional args