fix: apply theme accent color scale and other small tweaks#1768
Merged
fix: apply theme accent color scale and other small tweaks#1768
Conversation
- accent-100-1400 wasn't actually applied to spectrum, only actually matters in a few components (like checkboxes in lists), as most used other derived variables - enable stylelint on css files - change item list selected border color to match iris-grid selected border color - manually override selection border in spectrum lists and tables to not be hardcoded as blue and use accent - adjusted inactive bg color in light theme - fix mitre gaps in file list and command history list now that border is more visible
dsmmcken
changed the title
bmingles
approved these changes
Feb 2, 2024
Contributor
bmingles
left a comment
bmingles
left a comment
There was a problem hiding this comment.
Checked the mitre gaps and looks good. Verified that outlined button is now themed properly in styleguide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes small mitre gaps: