feat: always show close button on the active panel in a stack#1773
feat: always show close button on the active panel in a stack#1773
Conversation
- shows close button on active panels - removed transition so close button appears instantly on hover of non-active panel - added hover background to close button to make it stand-out a slightly more - adjusted overall tab size and spacing to be a little tighter - reduce minium tab size to 10ch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1773 +/- ##
=======================================
Coverage 46.10% 46.10%
=======================================
Files 627 627
Lines 37622 37622
Branches 9470 9470
=======================================
Hits 17345 17345
Misses 20222 20222
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dsmmcken
changed the title
mattrunyon
left a comment
mattrunyon
left a comment
There was a problem hiding this comment.
Did you add a bit more shadow to the tabs to give a little more depth to them?
No. Are you basing that on the diff of tests/golden-layout.spec.ts-snapshots/tests-golden-layout-operations-golden-layout-can-drag-tab-to-left-edge-2 images? Shadows were changed in a previous PR, but I guess playwright decided the shadow change alone was within tolerance to not regenerate. This PR actually changes the tab width, which is enough of a diff. |
|
Yep just looking at the diffs I noticed a more prominent shadow |
2 participants
Based on user feedback, we've made close buttons a little more prominent. Mainly the active tab in a stack now always shows it's close button. This mirrors behaviour in other IDEs like vs code. The intent is this will make it slightly less likely to accidently close tabs.
Summary:
Changes: