fix: Bind this to utils that moved from static to non-static with js api de-globalization#1795
Merged
mattrunyon merged 5 commits intodeephaven:mainfrom Feb 12, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1795 +/- ##
==========================================
- Coverage 46.05% 46.04% -0.01%
==========================================
Files 628 628
Lines 37784 37781 -3
Branches 9516 9516
==========================================
- Hits 17400 17397 -3
Misses 20330 20330
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vbabich
reviewed
Feb 12, 2024
| this.handleGotoValueSelectedFilterChanged.bind(this); | ||
| this.handleGotoValueChanged = this.handleGotoValueChanged.bind(this); | ||
| this.handleGotoValueSubmitted = this.handleGotoValueSubmitted.bind(this); | ||
| this.makeQuickFilter = this.makeQuickFilter.bind(this); |
Collaborator
There was a problem hiding this comment.
Do we call this makeQuickFilter with the wrong context somewhere?
Collaborator
Author
There was a problem hiding this comment.
Not that I'm aware of, it was just something that was a static method before de-globalization and is no longer static
Collaborator
There was a problem hiding this comment.
Got it, I couldn't find it either. Probably not necessary to bind then, but doesn't matter since we are doing bindAll in other places.
vbabich
previously approved these changes
Feb 12, 2024
vbabich
approved these changes
Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this issue while investigating deephaven/deephaven-plugins#179 and switching a param of
(v) => this.chartUtils.unwrapValue(v)to justthis.chartUtils.unwrapValueLooked through the other de-globalization PRs and added
bindAllMethodsto any classes where there were some static methods moved to non-static so that they can be used this way