feat: Picker Component#1821
Merged
bmingles merged 23 commits intodeephaven:mainfrom Feb 27, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1821 +/- ##
==========================================
- Coverage 46.11% 46.01% -0.11%
==========================================
Files 628 635 +7
Lines 37822 37887 +65
Branches 9529 9550 +21
==========================================
- Hits 17440 17432 -8
- Misses 20328 20401 +73
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
previously approved these changes
Feb 26, 2024
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Looks good overall, couple of comments about docs
Comment on lines
+8
to
+11
| export type PickerItemKey = Key | boolean; | ||
| export type PickerSelectionChangeHandler = (key: PickerItemKey) => void; | ||
|
|
||
| export interface NormalizedPickerItem { |
Member
There was a problem hiding this comment.
I think a comment about why we're defining a PickerItemKey and NormalizedPickerItem here would be beneficial.
Comment on lines
+28
to
+29
| /** Handler that is called when the selection changes. */ | ||
| onSelectionChange?: (key: PickerItemKey) => void; |
Member
There was a problem hiding this comment.
Perhaps we should mark this as deprecated to encourage usage of onChange instead?
mofojed
approved these changes
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports deephaven/deephaven-plugins#292