Skip to content

refactor: Create SlideTransition and FadeTransition components#1871

Merged
mofojed merged 6 commits intodeephaven:mainfrom
mofojed:transitions
Mar 22, 2024
Merged

refactor: Create SlideTransition and FadeTransition components#1871
mofojed merged 6 commits intodeephaven:mainfrom
mofojed:transitions

Conversation

@mofojed
Copy link
Copy Markdown
Member

@mofojed mofojed commented Mar 15, 2024

  • Create some components to wrap CSSTransition
  • Don't have to hardcode class names
  • Update tests and docs

mofojed added 2 commits March 15, 2024 10:49
- Create some components to wrap CSSTransition
- Don't have to hardcode class names
@mofojed mofojed requested a review from dsmmcken March 15, 2024 15:21
@mofojed mofojed self-assigned this Mar 15, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 46.11%. Comparing base (29353c2) to head (b090681).

Files Patch % Lines
...ges/components/src/transitions/SlideTransition.tsx 0.00% 4 Missing ⚠️
...ages/components/src/transitions/FadeTransition.tsx 0.00% 3 Missing ⚠️
packages/dashboard/src/DashboardUtils.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1871      +/-   ##
==========================================
- Coverage   46.12%   46.11%   -0.01%     
==========================================
  Files         635      637       +2     
  Lines       38047    38054       +7     
  Branches     9617     9620       +3     
==========================================
  Hits        17549    17549              
- Misses      20445    20452       +7     
  Partials       53       53              
Flag Coverage Δ
unit 46.11% <27.27%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@dsmmcken dsmmcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor feedback.

Comment thread packages/components/src/transitions/SlideTransition.tsx Outdated
Comment thread packages/iris-grid/src/IrisGrid.tsx Outdated
@mofojed mofojed requested a review from dsmmcken March 18, 2024 20:11
@mofojed mofojed enabled auto-merge (squash) March 18, 2024 20:45
@mofojed mofojed disabled auto-merge March 18, 2024 20:45
@mofojed mofojed enabled auto-merge (squash) March 18, 2024 20:45
@mofojed mofojed merged commit 991af44 into deephaven:main Mar 22, 2024
@mofojed mofojed deleted the transitions branch March 22, 2024 14:41
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants