refactor: Create SlideTransition and FadeTransition components#1871
Merged
mofojed merged 6 commits intodeephaven:mainfrom Mar 22, 2024
Merged
refactor: Create SlideTransition and FadeTransition components#1871mofojed merged 6 commits intodeephaven:mainfrom
mofojed merged 6 commits intodeephaven:mainfrom
Conversation
Member
mofojed
commented
Mar 15, 2024
- Create some components to wrap CSSTransition
- Don't have to hardcode class names
- Update tests and docs
- Create some components to wrap CSSTransition - Don't have to hardcode class names
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1871 +/- ##
==========================================
- Coverage 46.12% 46.11% -0.01%
==========================================
Files 635 637 +2
Lines 38047 38054 +7
Branches 9617 9620 +3
==========================================
Hits 17549 17549
- Misses 20445 20452 +7
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dsmmcken
reviewed
Mar 18, 2024
Co-authored-by: Don <dsmmcken@gmail.com>
dsmmcken
approved these changes
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.