feat: log export blacklist#1881
feat: log export blacklist#1881wusteven815 merged 9 commits intodeephaven:mainfrom wusteven815:export-log-blacklist
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1881 +/- ##
==========================================
+ Coverage 46.14% 46.22% +0.07%
==========================================
Files 636 647 +11
Lines 38072 38283 +211
Branches 9628 9687 +59
==========================================
+ Hits 17570 17698 +128
- Misses 20449 20532 +83
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Do we still want to blacklist the |
|
@wusteven815 yes we should blacklist connection as well. |
|
We should blacklist these top level keys as well as they're JS API items and don't seem to add anything useful from what I can tell
I think client is stored in redux in enterprise only as I don't see it in the exported logs on latest |
mofojed
left a comment
There was a problem hiding this comment.
We should be using JSON pointers. Also allow passing in a blacklist for Enterprise to use.
Here's an example exported from Enterprise for your testing benefit:
redux.json
client is at the root, so no need to blacklist everything.
|
I noticed that |
|
@wusteven815 yes it is |
mofojed
left a comment
There was a problem hiding this comment.
Looks good. Should blacklist dashboardData.default.connection and dashboardData.default.sessionWrapper.dh as well.
mattrunyon
left a comment
There was a problem hiding this comment.
We should move this into one of the util packages so DHE can use it with its own blacklist, but that can be a separate PR.
JSON.stringifyto filter out blacklisted pathapi,client,dashboardData.defaultLayout.connection,layoutStorage,storage