fix: Add isInvalid prop to Select component#1883
Merged
vbabich merged 3 commits intodeephaven:mainfrom Apr 3, 2024
Merged
Conversation
dsmmcken
previously requested changes
Mar 21, 2024
Contributor
dsmmcken
left a comment
dsmmcken
left a comment
There was a problem hiding this comment.
Please add an example in the styleguide after <Select> showing a <Select isInvalid>
mofojed
reviewed
Mar 25, 2024
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Looks good, just add to styleguide
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1883 +/- ##
==========================================
- Coverage 46.20% 46.20% -0.01%
==========================================
Files 641 641
Lines 38218 38219 +1
Branches 9670 9670
==========================================
Hits 17659 17659
- Misses 20506 20507 +1
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vbabich
force-pushed
the
add-is-invalid-prop-to-select
branch
from
8a25807 to
286d769
Compare
vbabich
force-pushed
the
add-is-invalid-prop-to-select
branch
from
286d769 to
f29ceb8
Compare
mofojed
approved these changes
Apr 3, 2024
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Annoying we had to update all those snapshots...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIxes #1882