feat: Change autoclosing bracket behavior to beforeWhitespace#1905
Merged
mattrunyon merged 1 commit intodeephaven:mainfrom Mar 27, 2024
Merged
feat: Change autoclosing bracket behavior to beforeWhitespace#1905mattrunyon merged 1 commit intodeephaven:mainfrom
mattrunyon merged 1 commit intodeephaven:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1905 +/- ##
=======================================
Coverage 46.11% 46.11%
=======================================
Files 637 637
Lines 38054 38054
Branches 9620 9620
=======================================
Hits 17549 17549
Misses 20452 20452
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
approved these changes
Mar 27, 2024
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Yea I'd probably centralize with a default settings wrapper or something; the editors do have a couple different options between them, though yes a lot of the settings are universal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked enterprise and we don't call
editor.createanywhere there. We should really centralize these inMonacoUtilswith acreateEditoror something, but not doing that here.