feat: Picker - Get formatter settings from context#1906
Closed
bmingles wants to merge 2 commits intodeephaven:mainfrom
Closed
feat: Picker - Get formatter settings from context#1906bmingles wants to merge 2 commits intodeephaven:mainfrom
bmingles wants to merge 2 commits intodeephaven:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1906 +/- ##
==========================================
- Coverage 46.20% 46.18% -0.03%
==========================================
Files 641 644 +3
Lines 38218 38237 +19
Branches 9670 9676 +6
==========================================
Hits 17659 17659
- Misses 20506 20525 +19
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bmingles
commented
Mar 27, 2024
| showNullStrings, | ||
| }: FormatterOptions = {}): UseFormatterResult { | ||
| const dh = useApi(); | ||
| const formatSettings = useFormatSettings(); |
Contributor
Author
There was a problem hiding this comment.
The other option that occurs to me is to pass formatSettings in as an arg instead of the overrides and then get rid of the useFormatSettings hook + context. Then could pass in formatSettings to the JS API Picker component as a prop and have the plugin wrapper provide it from the Redux store.
Contributor
Author
|
Replaced by /pull/1907 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Likely going to replace this PR with simpler version #1907
resolves #1889