feat: Picker - initial scroll position#1942
Merged
bmingles merged 30 commits intodeephaven:mainfrom Apr 24, 2024
Merged
Conversation
36fe15d to
703268b
Compare
mofojed
reviewed
Apr 24, 2024
mofojed
reviewed
Apr 24, 2024
mofojed
reviewed
Apr 24, 2024
mofojed
reviewed
Apr 24, 2024
mofojed
requested changes
Apr 24, 2024
Member
mofojed
left a comment
There was a problem hiding this comment.
Some minor cleanup, otherwise looks good.
mofojed
approved these changes
Apr 24, 2024
8ae77ea to
1f37fde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This PR depends on deephaven/deephaven-plugins#424 in order for element type checks to work for
Item,Text,Section, etc.icon_column#1890 should do the same for ListView, and we should be able to delete some of the normalization code)Testing
This illustrates different configurations and shows how initial scroll behavior differs for Pickers with plain items, descriptions, or sections:
resolves #1935