Skip to content

feat: ComboBoxNormalized - windowed data component#2072

Merged
bmingles merged 8 commits intodeephaven:mainfrom
bmingles:2071-combobox-jsapi
Jun 19, 2024
Merged

feat: ComboBoxNormalized - windowed data component#2072
bmingles merged 8 commits intodeephaven:mainfrom
bmingles:2071-combobox-jsapi

Conversation

@bmingles
Copy link
Copy Markdown
Contributor

@bmingles bmingles commented Jun 12, 2024

  • Created ComboBoxNormalized component. This component handles normalized item and section data which is needed to support windowed data. (there will be 1 more PR providing the ComboBox component in the jsapi-components package that will handle the table support. Similar to Picker)
  • Styleguide example showing controlled data + validation for no selection
  • Split out usePickerNormalizedProps hook from PickerNormalized so that the logic could be reused in ComboBoxNormalized
  • Cleaned up some generics for utils using Spectrum DomRef

resolves #2071

@bmingles bmingles marked this pull request as ready for review June 12, 2024 21:57
@bmingles bmingles changed the title feat: ComboBox - jsapi component feat: ComboBoxNormalized - windowed data component Jun 12, 2024
@bmingles bmingles requested a review from mofojed June 12, 2024 21:58
@bmingles bmingles self-assigned this Jun 12, 2024
@bmingles bmingles force-pushed the 2071-combobox-jsapi branch from 94737da to a13a798 Compare June 17, 2024 14:58
@bmingles bmingles merged commit a30341a into deephaven:main Jun 19, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 19, 2024
@bmingles bmingles deleted the 2071-combobox-jsapi branch June 20, 2024 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ComboBoxNormalized - @deephaven/components

2 participants