fix: Allow ComboBox to accept the FocusableRef for ref#2121
Merged
mofojed merged 1 commit intodeephaven:mainfrom Jul 3, 2024
Merged
fix: Allow ComboBox to accept the FocusableRef for ref#2121mofojed merged 1 commit intodeephaven:mainfrom
mofojed merged 1 commit intodeephaven:mainfrom
Conversation
Member
mofojed
commented
Jul 3, 2024
mofojed
commented
- Wasn't allowing a ref to be passed in to ComboBox
- Wasn't allowing a ref to be passed in to ComboBox
bmingles
approved these changes
Jul 3, 2024
Contributor
bmingles
left a comment
bmingles
left a comment
There was a problem hiding this comment.
Ah yeah. Good catch.
Guessing we probably need this for Picker as well.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2121 +/- ##
==========================================
- Coverage 46.59% 46.58% -0.01%
==========================================
Files 681 681
Lines 38430 38431 +1
Branches 9576 9786 +210
==========================================
Hits 17905 17905
+ Misses 20515 20474 -41
- Partials 10 52 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.