Skip to content

fix: error when edited cell is out of grid viewport #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AkshatJawne merged 3 commits into from
Jul 17, 2024
Merged

fix: error when edited cell is out of grid viewport #2148

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4bed0f
WIP diagnosing problem
AkshatJawne Jul 15, 2024
be973ca
fix: error when edited cell is out of grid viewport
AkshatJawne Jul 16, 2024
9fd7a75
remove unneccessary eslint comment
AkshatJawne Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions packages/grid/src/Grid.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2167,15 +2167,25 @@ class Grid extends PureComponent<GridProps, GridState> {
}
: { opacity: 0 };

const modelColumn = this.getModelColumn(column);
const modelRow = this.getModelRow(row);
let modelColumn;
let modelRow;
try {
modelColumn = this.getModelColumn(column);
modelRow = this.getModelRow(row);
} catch (e) {
// eslint-disable-next-line no-console
Comment thread
AkshatJawne marked this conversation as resolved.
Outdated
return null;
}
const inputStyle: CSSProperties | undefined =
modelColumn != null && modelRow != null
? {
textAlign: model.textAlignForCell(modelColumn, modelRow),
}
: undefined;
const isValid = model.isValidForCell(modelColumn, modelRow, value);
const isValid =
modelColumn != null && modelRow != null
? model.isValidForCell(modelColumn, modelRow, value)
: false;

return (
<div style={wrapperStyle}>
Expand Down
⚡