Skip to content

feat: Make rollup group behaviour a setting in the global settings menu #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AkshatJawne merged 27 commits into from
Sep 3, 2024
Merged

feat: Make rollup group behaviour a setting in the global settings menu #2183

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
fd14237
WIP
AkshatJawne Aug 8, 2024
3941b7c
WIP
AkshatJawne Aug 12, 2024
60a585f
WIP
AkshatJawne Aug 12, 2024
7a5d4e2
WIP
AkshatJawne Aug 12, 2024
a25bd9a
modify Updater
AkshatJawne Aug 13, 2024
fd20dd0
modify test case
AkshatJawne Aug 14, 2024
55c315a
modify logic
AkshatJawne Aug 15, 2024
4092e79
make review changes
AkshatJawne Aug 15, 2024
d5ebdd0
remove unneccessary import
AkshatJawne Aug 15, 2024
32faad6
Merge branch 'main' into 2128_rollup_settings
AkshatJawne Aug 19, 2024
e98abba
add snapshots
AkshatJawne Aug 19, 2024
b8f3213
make change to object
AkshatJawne Aug 19, 2024
8c80230
make changes according to review
AkshatJawne Aug 21, 2024
1cbc60d
address PR comments
AkshatJawne Aug 22, 2024
f0ca4ab
adjust formatter test
AkshatJawne Aug 22, 2024
7d8fc95
add exceptions
AkshatJawne Aug 22, 2024
68a4148
remove exceptions
AkshatJawne Aug 22, 2024
7d8f09e
add back deps
AkshatJawne Aug 22, 2024
bb7c663
make changes based on comment
AkshatJawne Aug 22, 2024
024db4f
Merge branch 'main' into 2128_rollup_settings
AkshatJawne Aug 22, 2024
ca8f90b
update snapshots
AkshatJawne Aug 23, 2024
a1bd2eb
resolve conflicts
AkshatJawne Aug 23, 2024
2fa7306
readd formatter check and update snapshots
AkshatJawne Aug 23, 2024
fa517e3
update check and snapshots
AkshatJawne Aug 23, 2024
48d061d
get snapshots from main
AkshatJawne Aug 23, 2024
f10645a
alter test case
AkshatJawne Aug 23, 2024
06d3433
fix test case
AkshatJawne Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/iris-grid/src/IrisGridModelUpdater.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ function IrisGridModelUpdater({
model.rollupConfig = rollupConfig;
}
},
[model, rollupConfig]
// eslint-disable-next-line react-hooks/exhaustive-deps
[model, model.rollupConfig, rollupConfig]
Comment thread
AkshatJawne marked this conversation as resolved.
Outdated
);
useOnChange(
function updateSelectDistinctColumns() {
Expand All @@ -159,7 +160,8 @@ function IrisGridModelUpdater({
model.totalsConfig = totalsConfig;
}
},
[model, totalsConfig]
// eslint-disable-next-line react-hooks/exhaustive-deps
[model, model.isTotalsAvailable, totalsConfig]
);
useOnChange(
function updatePendingRowCount() {
Expand Down
⚡