fix: DH-17730: Fix Proxy Model Undefined Formatter#2237
Merged
dgodinez-dh merged 1 commit intodeephaven:mainfrom Sep 26, 2024
Merged
fix: DH-17730: Fix Proxy Model Undefined Formatter#2237dgodinez-dh merged 1 commit intodeephaven:mainfrom
dgodinez-dh merged 1 commit intodeephaven:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2237 +/- ##
==========================================
- Coverage 46.64% 46.42% -0.22%
==========================================
Files 694 698 +4
Lines 38517 38751 +234
Branches 9742 9677 -65
==========================================
+ Hits 17965 17991 +26
- Misses 20499 20749 +250
+ Partials 53 11 -42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vbabich
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://deephaven.atlassian.net/browse/DH-17730 in Enterprise. Will need to be cherry picked back to v0.85.
web-client-ui issue is #2234