refactor: DH-17778: Move exportLogs to the log package#2279
refactor: DH-17778: Move exportLogs to the log package#2279vbabich merged 13 commits intodeephaven:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2279 +/- ##
==========================================
+ Coverage 46.57% 46.62% +0.05%
==========================================
Files 698 702 +4
Lines 38767 38937 +170
Branches 9866 9902 +36
==========================================
+ Hits 18054 18153 +99
- Misses 20702 20730 +28
- Partials 11 54 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
||
| logInit(); | ||
| logInit( | ||
| parseInt(import.meta.env.VITE_LOG_LEVEL ?? '', 10), |
There was a problem hiding this comment.
Is it ok that '' parses to NaN?
There was a problem hiding this comment.
This is existing code moved from LogInit - https://github.com/deephaven/web-client-ui/pull/2279/files#diff-8f738bb62eda99bdb9b608feb9a011431c9daef91788b6ad56166ff4d950ca9eL15
I don't know if this was the original intent, but NaN here results in a warning -
if (!Number.isFinite(level)) {
console.warn(
`Expected a number for log level. Received: ${level}. Ignoring`
);
return;
}
| FILENAME_DATE_FORMAT, | ||
| new Date() | ||
| )}_support_logs`, | ||
| logHistory: LogHistory, |
There was a problem hiding this comment.
Should this be marked as a breaking change in the PR?
There was a problem hiding this comment.
The exportLogs wasn't previously exposed. The @deephaven/code-studio package didn't export anything from LogExport.ts.
exportLogsandlogInitto thelogpackage so they could be reused in Enterprise@deephaven/reduxand@deephaven/jsapi-shimdependencies fromLogExport.tsgetReduxDataString