Skip to content

fix: open file blocks logout#2281

Merged
wusteven815 merged 2 commits intodeephaven:mainfrom
wusteven815:1685-open-file-logout
Nov 28, 2024
Merged

fix: open file blocks logout#2281
wusteven815 merged 2 commits intodeephaven:mainfrom
wusteven815:1685-open-file-logout

Conversation

@wusteven815
Copy link
Copy Markdown
Contributor

@wusteven815
Copy link
Copy Markdown
Contributor Author

There seems to be a race condition where if a file is open, AuthPluginPsk gets destroyed before its logout event is received. This delays the state change that causes a remount, so that the logout event is reached in time.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.60%. Comparing base (5ebc195) to head (d99b4a5).

Files with missing lines Patch % Lines
packages/app-utils/src/components/AppBootstrap.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2281      +/-   ##
==========================================
- Coverage   46.60%   46.60%   -0.01%     
==========================================
  Files         704      704              
  Lines       38963    38964       +1     
  Branches     9914     9729     -185     
==========================================
  Hits        18158    18158              
- Misses      20794    20795       +1     
  Partials       11       11              
Flag Coverage Δ
unit 46.60% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wusteven815 wusteven815 marked this pull request as ready for review November 8, 2024 15:46
@wusteven815 wusteven815 requested review from a team and vbabich and removed request for a team November 8, 2024 15:46
@wusteven815 wusteven815 self-assigned this Nov 8, 2024
@wusteven815 wusteven815 merged commit 7ff0e53 into deephaven:main Nov 28, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Open file blocks logout

2 participants