fix: open file blocks logout#2281
Merged
wusteven815 merged 2 commits intodeephaven:mainfrom Nov 28, 2024
wusteven815:1685-open-file-logout
Merged
fix: open file blocks logout#2281wusteven815 merged 2 commits intodeephaven:mainfrom wusteven815:1685-open-file-logout
wusteven815 merged 2 commits intodeephaven:mainfrom
wusteven815:1685-open-file-logout
Conversation
Contributor
Author
|
There seems to be a race condition where if a file is open, |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2281 +/- ##
==========================================
- Coverage 46.60% 46.60% -0.01%
==========================================
Files 704 704
Lines 38963 38964 +1
Branches 9914 9729 -185
==========================================
Hits 18158 18158
- Misses 20794 20795 +1
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
approved these changes
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AuthPluginPskremount so the broadcast message is received in time