feat: Add indicator theme variables#2344
Merged
jnumainville merged 4 commits intodeephaven:mainfrom Feb 7, 2025
Merged
Conversation
mofojed
requested changes
Jan 20, 2025
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
You'll need to run npm run e2e:update-ci-snapshots
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2344 +/- ##
==========================================
- Coverage 46.70% 46.09% -0.62%
==========================================
Files 704 712 +8
Lines 39044 39681 +637
Branches 9757 9870 +113
==========================================
+ Hits 18234 18289 +55
- Misses 20799 21381 +582
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds theme variables for indicator