Skip to content

fix: Paste option shows when it shouldn't#2364

Merged
ericlln merged 2 commits intodeephaven:mainfrom
ericlln:DH-18624-paste-option-shows-when-it-shouldn't
Feb 7, 2025
Merged

fix: Paste option shows when it shouldn't#2364
ericlln merged 2 commits intodeephaven:mainfrom
ericlln:DH-18624-paste-option-shows-when-it-shouldn't

Conversation

@ericlln
Copy link
Copy Markdown
Contributor

@ericlln ericlln commented Feb 6, 2025

Useful snippet for testing

from deephaven import empty_table, input_table
source = empty_table(10).update(["X = i", "Y = i"])
result = input_table(init_table=source)
  • The source table is not an input table and now has no option to paste into any cells
  • The result table is an input table, and the option to paste will appear only if the current selection can be pasted into

@ericlln ericlln requested a review from a team February 6, 2025 22:23
@ericlln ericlln self-assigned this Feb 6, 2025
@ericlln ericlln requested review from dgodinez-dh and removed request for a team February 6, 2025 22:23
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 46.74%. Comparing base (9d49873) to head (f471069).

Files with missing lines Patch % Lines
...d/src/mousehandlers/IrisGridContextMenuHandler.tsx 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2364      +/-   ##
==========================================
- Coverage   46.75%   46.74%   -0.02%     
==========================================
  Files         710      710              
  Lines       39116    39125       +9     
  Branches     9775     9964     +189     
==========================================
  Hits        18289    18289              
- Misses      20816    20825       +9     
  Partials       11       11              
Flag Coverage Δ
unit 46.74% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericlln ericlln merged commit 0305522 into deephaven:main Feb 7, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants