fix: Partition aware source table UI widget swaps from merge to coalesce#2397
Merged
ericlln merged 6 commits intodeephaven:mainfrom Mar 28, 2025
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2397 +/- ##
==========================================
- Coverage 46.82% 46.82% -0.01%
==========================================
Files 711 711
Lines 39289 39295 +6
Branches 10007 9821 -186
==========================================
+ Hits 18398 18400 +2
- Misses 20837 20884 +47
+ Partials 54 11 -43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dgodinez-dh
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isPartitionAwareSourceTableinIrisGridTableModel.tsisn't always accurate astable.isUncoalescedis only true when no filters have been applied yet. Once a filter is applied, the table is no longer considered uncoalesced but the source table should still have the same property as before.