Skip to content

fix: Allow double and float types to be rollupable (#2311)#2408

Merged
mofojed merged 2 commits intodeephaven:release/v0.85from
mofojed:DH-19170-double-rollups
Apr 9, 2025
Merged

fix: Allow double and float types to be rollupable (#2311)#2408
mofojed merged 2 commits intodeephaven:release/v0.85from
mofojed:DH-19170-double-rollups

Conversation

@mofojed
Copy link
Copy Markdown
Member

@mofojed mofojed commented Apr 8, 2025

from deephaven import empty_table

doubles = empty_table(1_000_000).update_view(["Group = i*10.4", "N = (i % 347)*0.1", "M = (i % 29)*10.2", "Value=i*2.4", "Weight=i*4.2"])
floats = empty_table(1_000_000).update_view(["Group = i*10.4", "N = (float)(i % 347)*0.1", "M = (float)(i % 29)*10.2"
, "Value=(float)i*2.4", "Weight=(float)i*4.2"])
  • Updated e2e tests and unit tests

- We had this restriction in the UI, but the engine can actually handle
it
- Tested with doubles, floats
- Tested with the following tables:
```python
from deephaven import empty_table

doubles = empty_table(1_000_000).update_view(["Group = i*10.4", "N = (i % 347)*0.1", "M = (i % 29)*10.2", "Value=i*2.4", "Weight=i*4.2"])
floats = empty_table(1_000_000).update_view(["Group = i*10.4", "N = (float)(i % 347)*0.1", "M = (float)(i % 29)*10.2"
, "Value=(float)i*2.4", "Weight=(float)i*4.2"])
```
- Updated e2e tests and unit tests
- Fixes deephaven#2295 
- For DH-18030
@mofojed mofojed requested a review from a team April 8, 2025 20:31
@mofojed mofojed self-assigned this Apr 8, 2025
@mofojed mofojed requested review from vbabich and removed request for a team April 8, 2025 20:31
vbabich
vbabich previously approved these changes Apr 8, 2025
- Was importing from test-utils, which is not where TestUtils is located on v0.85
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.72%. Comparing base (37a7940) to head (5c51c1f).

Additional details and impacted files
@@              Coverage Diff               @@
##           release/v0.85    #2408   +/-   ##
==============================================
  Coverage          46.71%   46.72%           
==============================================
  Files                695      695           
  Lines              38871    38873    +2     
  Branches            9881     9883    +2     
==============================================
+ Hits               18159    18163    +4     
+ Misses             20660    20658    -2     
  Partials              52       52           
Flag Coverage Δ
unit 46.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mofojed mofojed merged commit d7dec90 into deephaven:release/v0.85 Apr 9, 2025
11 checks passed
@mofojed mofojed deleted the DH-19170-double-rollups branch April 9, 2025 14:30
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants