fix: Allow double and float types to be rollupable (#2311)#2408
Merged
mofojed merged 2 commits intodeephaven:release/v0.85from Apr 9, 2025
Merged
fix: Allow double and float types to be rollupable (#2311)#2408mofojed merged 2 commits intodeephaven:release/v0.85from
mofojed merged 2 commits intodeephaven:release/v0.85from
Conversation
Member
mofojed
commented
Apr 8, 2025
- Cherry-pick of Web UI should allow using doubles as rollup key columns #2295 to v0.85
- We had this restriction in the UI, but the engine can actually handle it
- Tested with doubles, floats
- Tested with the following tables:
- Updated e2e tests and unit tests
- We had this restriction in the UI, but the engine can actually handle it - Tested with doubles, floats - Tested with the following tables: ```python from deephaven import empty_table doubles = empty_table(1_000_000).update_view(["Group = i*10.4", "N = (i % 347)*0.1", "M = (i % 29)*10.2", "Value=i*2.4", "Weight=i*4.2"]) floats = empty_table(1_000_000).update_view(["Group = i*10.4", "N = (float)(i % 347)*0.1", "M = (float)(i % 29)*10.2" , "Value=(float)i*2.4", "Weight=(float)i*4.2"]) ``` - Updated e2e tests and unit tests - Fixes deephaven#2295 - For DH-18030
vbabich
previously approved these changes
Apr 8, 2025
- Was importing from test-utils, which is not where TestUtils is located on v0.85
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v0.85 #2408 +/- ##
==============================================
Coverage 46.71% 46.72%
==============================================
Files 695 695
Lines 38871 38873 +2
Branches 9881 9883 +2
==============================================
+ Hits 18159 18163 +4
+ Misses 20660 20658 -2
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vbabich
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.