Skip to content

fix: DH-17599: Change illegal characters to underscores in variable names#2409

Merged
vbabich merged 5 commits intodeephaven:mainfrom
vbabich:vlad_legalizeTableName_fix
Apr 9, 2025
Merged

fix: DH-17599: Change illegal characters to underscores in variable names#2409
vbabich merged 5 commits intodeephaven:mainfrom
vbabich:vlad_legalizeTableName_fix

Conversation

@vbabich
Copy link
Copy Markdown
Collaborator

@vbabich vbabich commented Apr 8, 2025

  • Add makeVariableName method to create valid variable names
  • Add/update unit tests.

@vbabich vbabich self-assigned this Apr 8, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.83%. Comparing base (0f4f238) to head (dcbaa80).

Files with missing lines Patch % Lines
packages/console/src/csv/CsvInputBar.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2409   +/-   ##
=======================================
  Coverage   46.83%   46.83%           
=======================================
  Files         711      711           
  Lines       39307    39310    +3     
  Branches     9822     9822           
=======================================
+ Hits        18408    18411    +3     
  Misses      20888    20888           
  Partials       11       11           
Flag Coverage Δ
unit 46.83% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vbabich vbabich changed the title DH-17599: Change illegal characters to underscores in variable names fix: DH-17599: Change illegal characters to underscores in variable names Apr 8, 2025
@vbabich vbabich requested a review from Copilot April 9, 2025 02:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

packages/utils/src/DbNameValidator.ts:76

  • [nitpick] The removal of the global ('g') flag from TABLE_NAME_PATTERN appears intentional since the pattern is anchored, but please ensure this change does not affect any multi-match behavior expected in other contexts.
const TABLE_NAME_PATTERN = /^[a-zA-Z_$][a-zA-Z0-9_$\-+@]*$/;

@vbabich vbabich marked this pull request as ready for review April 9, 2025 02:45
@vbabich vbabich requested a review from bmingles April 9, 2025 02:46
Copy link
Copy Markdown
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbabich vbabich merged commit 15c8cfe into deephaven:main Apr 9, 2025
12 of 13 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants