fix: DH-19138: Determine Totals Column Name by Num Aggs Per Column#2411
Merged
dgodinez-dh merged 1 commit intodeephaven:mainfrom Apr 9, 2025
Merged
fix: DH-19138: Determine Totals Column Name by Num Aggs Per Column#2411dgodinez-dh merged 1 commit intodeephaven:mainfrom
dgodinez-dh merged 1 commit intodeephaven:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2411 +/- ##
=======================================
Coverage 46.83% 46.83%
=======================================
Files 711 711
Lines 39310 39310
Branches 10011 10011
=======================================
Hits 18411 18411
Misses 20845 20845
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vbabich
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://deephaven.atlassian.net/browse/DH-19138
For totals table columns, we were applying renaming logic based on number of operations in the config, but it should be on number of operations for each given column.
E.g., for a config
{X : [SUM, COUNT], Y: [COUNT]}then your columns will be[X_SUM, X_COUNT, Y]but we were expecting[X_SUM, X_COUNT, Y_COUNT]