Skip to content

fix: DH-19138: Determine Totals Column Name by Num Aggs Per Column#2411

Merged
dgodinez-dh merged 1 commit intodeephaven:mainfrom
dgodinez-dh:dag_AggFix
Apr 9, 2025
Merged

fix: DH-19138: Determine Totals Column Name by Num Aggs Per Column#2411
dgodinez-dh merged 1 commit intodeephaven:mainfrom
dgodinez-dh:dag_AggFix

Conversation

@dgodinez-dh
Copy link
Copy Markdown
Contributor

https://deephaven.atlassian.net/browse/DH-19138
For totals table columns, we were applying renaming logic based on number of operations in the config, but it should be on number of operations for each given column.

E.g., for a config {X : [SUM, COUNT], Y: [COUNT]} then your columns will be [X_SUM, X_COUNT, Y] but we were expecting [X_SUM, X_COUNT, Y_COUNT]

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.83%. Comparing base (15c8cfe) to head (d651ddb).

Files with missing lines Patch % Lines
...ckages/iris-grid/src/IrisGridTableModelTemplate.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2411   +/-   ##
=======================================
  Coverage   46.83%   46.83%           
=======================================
  Files         711      711           
  Lines       39310    39310           
  Branches    10011    10011           
=======================================
  Hits        18411    18411           
  Misses      20845    20845           
  Partials       54       54           
Flag Coverage Δ
unit 46.83% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dgodinez-dh dgodinez-dh requested review from a team and vbabich and removed request for a team April 9, 2025 17:52
@dgodinez-dh dgodinez-dh merged commit 1909fac into deephaven:main Apr 9, 2025
11 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2025
@dgodinez-dh dgodinez-dh deleted the dag_AggFix branch April 22, 2025 18:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants