Skip to content

refactor: move getLatestSelection to GridSelectionMouseHandler#2412

Merged
ericlln merged 1 commit intodeephaven:mainfrom
ericlln:refactor-context-menu-using-stale-selection
Apr 9, 2025
Merged

refactor: move getLatestSelection to GridSelectionMouseHandler#2412
ericlln merged 1 commit intodeephaven:mainfrom
ericlln:refactor-context-menu-using-stale-selection

Conversation

@ericlln
Copy link
Copy Markdown
Contributor

@ericlln ericlln commented Apr 9, 2025

After merging in #2407, I thought a bit more about my implementation and decided to refactor it (before picking this back to v0.85)

It makes more sense for getLatestSelection to live in GridSelectionMouseHandler since its logic also depends on the implementation of onContextMenu in this class, and this will make it more straightforward for other mouse handlers that might want to use this method to get the Grid's most recent selected ranges.

@ericlln ericlln self-assigned this Apr 9, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.84%. Comparing base (c43f306) to head (a144891).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...d/src/mousehandlers/IrisGridContextMenuHandler.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2412   +/-   ##
=======================================
  Coverage   46.84%   46.84%           
=======================================
  Files         711      711           
  Lines       39316    39316           
  Branches     9825     9825           
=======================================
  Hits        18416    18416           
  Misses      20889    20889           
  Partials       11       11           
Flag Coverage Δ
unit 46.84% <83.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ericlln ericlln requested a review from vbabich April 9, 2025 19:52
@ericlln ericlln marked this pull request as ready for review April 9, 2025 20:08
@ericlln ericlln merged commit 23cefe3 into deephaven:main Apr 9, 2025
12 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants