refactor: move getLatestSelection to GridSelectionMouseHandler#2412
Merged
ericlln merged 1 commit intodeephaven:mainfrom Apr 9, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2412 +/- ##
=======================================
Coverage 46.84% 46.84%
=======================================
Files 711 711
Lines 39316 39316
Branches 9825 9825
=======================================
Hits 18416 18416
Misses 20889 20889
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vbabich
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging in #2407, I thought a bit more about my implementation and decided to refactor it (before picking this back to
v0.85)It makes more sense for
getLatestSelectionto live inGridSelectionMouseHandlersince its logic also depends on the implementation ofonContextMenuin this class, and this will make it more straightforward for other mouse handlers that might want to use this method to get the Grid's most recent selected ranges.