fix: DH-19614: Add tree table formatting logic to tree model#2461
Conversation
53fdfa7 to
42b1a14
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2461 +/- ##
==========================================
+ Coverage 47.31% 47.35% +0.03%
==========================================
Files 723 727 +4
Lines 39772 39833 +61
Branches 10144 9975 -169
==========================================
+ Hits 18819 18861 +42
- Misses 20899 20961 +62
+ Partials 54 11 -43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
We'll want to add unit tests/e2e tests for that |
While working on the e2e tests, I discovered a separate formatting issue and created a new ticket for it: DH-19693. Since this issue isn’t directly related to the color and alignment changes in the original ticket, I’m planning to wrap it up without the e2e tests for now. Then, once DH-19693 is resolved, I'll complete the e2e tests and submit them in a separate PR. |
Part of DH-19614. Fixes an issue with rollups where tree table aggregated constituents were not being rendered based on the original column type. This change ensures that leaf nodes in tree tables use the appropriate column type for formatting and alignment.
Changes:
IrisGridTreeTableModel:colorForCellto usecolumn.constituentTypeinstead ofcolumn,typefor leaf node valuestextAlignForCellto usecolumn.constituentTypefor leaf node valuesisUITreeRowfunction inIrisGridTreeTableModel.ts