feat: Added displayName to React contexts#2512
Conversation
… React dev tools (DH-19529)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2512 +/- ##
==========================================
+ Coverage 44.59% 44.61% +0.02%
==========================================
Files 763 763
Lines 42700 42720 +20
Branches 10741 10938 +197
==========================================
+ Hits 19041 19059 +18
+ Misses 23648 23603 -45
- Partials 11 58 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mattrunyon
left a comment
There was a problem hiding this comment.
The branch has a different ticket number from the PR title. I'm also not sure how this change applies to the ticket in branch name or PR title.
We should try to formalize this, but at least what I've been doing if I needed multiple PRs for a fix is not putting the ticket name in the title of the first PR. So web-client-ui doesn't get the ticket number, the plugins repo does so the ticket doesn't get moved to RTT based on just a web-client-ui update.
Also, would we want to enable an eslint rule for this? We already have it for other components. Looks like it's just a boolean option we can enable here
|
@mattrunyon I fixed the PR title. I'll leave the Jira in the title for now until we get something more formal. I will just manually move the ticket back for now. Have already been doing so on this particular one. For the eslint rule, I think that's a good idea, but looks like the version of eslint-plugin-react we are using does not have that option. I attempted it but got an error. Package lock suggests we are on 7.31.11 which doesn't seem to have that option yet: I don't want to bring in the scope to upgrade eslint on this PR since I kind of slipped this in to support some sleuthing I was doing. |
mattrunyon
left a comment
There was a problem hiding this comment.
Asked Bender and he said let's remove the ticket number from the PR title so it doesn't look like the ticket should be moved to RTT when the package update happens in DHE
I put the ticket number in the body though so it has a reference still, but only the title goes in the changelog on release
Added displayName to React contexts so that they can be identified in React dev tools.
Part of DH-19529
Testing
npm start