Skip to content

fix: DH-18648: Ensure grid panel doesn't crash when Pandas query restarted#2528

Merged
mofojed merged 1 commit intodeephaven:mainfrom
mofojed:bender_DH-18648
Sep 4, 2025
Merged

fix: DH-18648: Ensure grid panel doesn't crash when Pandas query restarted#2528
mofojed merged 1 commit intodeephaven:mainfrom
mofojed:bender_DH-18648

Conversation

@mofojed
Copy link
Copy Markdown
Member

@mofojed mofojed commented Sep 4, 2025

…arted

- Taking part of deephaven-ent/iris#2572, but only need to reset the model on disconnect in G+
- The model is refetched the query is restarted
- Tested against dev-gplus, created a query there with some pandas data frames
@mofojed mofojed requested a review from dgodinez-dh September 4, 2025 14:28
@mofojed mofojed self-assigned this Sep 4, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.59%. Comparing base (4c2561c) to head (021b8a2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../dashboard-core-plugins/src/panels/PandasPanel.tsx 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2528      +/-   ##
==========================================
- Coverage   44.61%   44.59%   -0.03%     
==========================================
  Files         764      764              
  Lines       42800    42825      +25     
  Branches    10964    10769     -195     
==========================================
  Hits        19096    19096              
- Misses      23693    23718      +25     
  Partials       11       11              
Flag Coverage Δ
unit 44.59% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mofojed mofojed merged commit 9c969f0 into deephaven:main Sep 4, 2025
11 checks passed
@mofojed mofojed deleted the bender_DH-18648 branch September 4, 2025 20:41
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants