fix: DH-18648: Ensure grid panel doesn't crash when Pandas query restarted#2528
Merged
mofojed merged 1 commit intodeephaven:mainfrom Sep 4, 2025
Merged
fix: DH-18648: Ensure grid panel doesn't crash when Pandas query restarted#2528mofojed merged 1 commit intodeephaven:mainfrom
mofojed merged 1 commit intodeephaven:mainfrom
Conversation
Member
mofojed
commented
Sep 4, 2025
- Taking part of https://github.com/deephaven-ent/iris/pull/2572, but only need to reset the model on disconnect in G+
- The model is refetched the query is restarted
- Tested against dev-gplus, created a query there with some pandas data frames
…arted - Taking part of deephaven-ent/iris#2572, but only need to reset the model on disconnect in G+ - The model is refetched the query is restarted - Tested against dev-gplus, created a query there with some pandas data frames
dgodinez-dh
approved these changes
Sep 4, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2528 +/- ##
==========================================
- Coverage 44.61% 44.59% -0.03%
==========================================
Files 764 764
Lines 42800 42825 +25
Branches 10964 10769 -195
==========================================
Hits 19096 19096
- Misses 23693 23718 +25
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.