fix: Pass optional expandDescendants arg to setColumnExpanded#2540
Merged
vbabich merged 4 commits intodeephaven:mainfrom Oct 2, 2025
Merged
fix: Pass optional expandDescendants arg to setColumnExpanded#2540vbabich merged 4 commits intodeephaven:mainfrom
vbabich merged 4 commits intodeephaven:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2540 +/- ##
========================================
Coverage 44.95% 44.95%
========================================
Files 765 765
Lines 42917 42920 +3
Branches 10796 10998 +202
========================================
+ Hits 19293 19296 +3
+ Misses 23611 23563 -48
- Partials 13 61 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bmingles
reviewed
Oct 1, 2025
bmingles
requested changes
Oct 1, 2025
Contributor
bmingles
left a comment
There was a problem hiding this comment.
Looks good overall. Left comment about 1 place you could use your new MouseHandlersProp type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expandDescendantsarg tosetColumnExpandedIrisGridPaneltoIrisGrid