fix: DH-20500: Links without operators not working#2541
Merged
mattrunyon merged 2 commits intodeephaven:mainfrom Oct 2, 2025
Merged
fix: DH-20500: Links without operators not working#2541mattrunyon merged 2 commits intodeephaven:mainfrom
mattrunyon merged 2 commits intodeephaven:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2541 +/- ##
=======================================
Coverage 44.95% 44.95%
=======================================
Files 765 765
Lines 42917 42918 +1
Branches 10796 10797 +1
=======================================
+ Hits 19293 19294 +1
Misses 23611 23611
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vbabich
previously approved these changes
Sep 30, 2025
vbabich
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check was added here and caused links created before we had an operator to not function. We have logic that defaults to equals effectively if the operator does not exist.
We may want to clean that up and add a default in the future to migrate any old links, but this is the simple fix for now and there's not much harm in it