Skip to content

fix: DH-20500: Links without operators not working#2541

Merged
mattrunyon merged 2 commits intodeephaven:mainfrom
mattrunyon:DH-20500
Oct 2, 2025
Merged

fix: DH-20500: Links without operators not working#2541
mattrunyon merged 2 commits intodeephaven:mainfrom
mattrunyon:DH-20500

Conversation

@mattrunyon
Copy link
Copy Markdown
Collaborator

This check was added here and caused links created before we had an operator to not function. We have logic that defaults to equals effectively if the operator does not exist.

We may want to clean that up and add a default in the future to migrate any old links, but this is the simple fix for now and there's not much harm in it

@mattrunyon mattrunyon requested a review from a team September 30, 2025 22:41
@mattrunyon mattrunyon self-assigned this Sep 30, 2025
@mattrunyon mattrunyon requested review from vbabich and removed request for a team September 30, 2025 22:41
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 44.95%. Comparing base (f7fe8ad) to head (841a0de).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...kages/dashboard-core-plugins/src/linker/Linker.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2541   +/-   ##
=======================================
  Coverage   44.95%   44.95%           
=======================================
  Files         765      765           
  Lines       42917    42918    +1     
  Branches    10796    10797    +1     
=======================================
+ Hits        19293    19294    +1     
  Misses      23611    23611           
  Partials       13       13           
Flag Coverage Δ
unit 44.95% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

vbabich
vbabich previously approved these changes Sep 30, 2025
@mattrunyon mattrunyon merged commit cbb4fc5 into deephaven:main Oct 2, 2025
11 checks passed
@mattrunyon mattrunyon deleted the DH-20500 branch October 2, 2025 17:59
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants