fix: Accept all HasEventHandling types when creating event Promise#2550
Merged
mofojed merged 2 commits intodeephaven:mainfrom Oct 16, 2025
Merged
Conversation
Member
mofojed
commented
Oct 14, 2025
- Shouldn't have limited this function to just table types
- Shouldn't have limited this function to just table types
dgodinez-dh
reviewed
Oct 15, 2025
Contributor
dgodinez-dh
left a comment
There was a problem hiding this comment.
Looks like TS is unhappy with the removal of type on some imports. But the removal looks intentional.
- I don't know how they got removed
Member
Author
|
I don't know how the type got removed on those imports, that was not intentional. Added them back. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2550 +/- ##
==========================================
+ Coverage 44.12% 44.33% +0.21%
==========================================
Files 763 764 +1
Lines 42906 43050 +144
Branches 10827 10869 +42
==========================================
+ Hits 18932 19087 +155
+ Misses 23959 23947 -12
- Partials 15 16 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dgodinez-dh
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.