Skip to content

fix: Accept all HasEventHandling types when creating event Promise#2550

Merged
mofojed merged 2 commits intodeephaven:mainfrom
mofojed:make-cancelable-event-promise-update
Oct 16, 2025
Merged

fix: Accept all HasEventHandling types when creating event Promise#2550
mofojed merged 2 commits intodeephaven:mainfrom
mofojed:make-cancelable-event-promise-update

Conversation

@mofojed
Copy link
Copy Markdown
Member

@mofojed mofojed commented Oct 14, 2025

  • Shouldn't have limited this function to just table types

- Shouldn't have limited this function to just table types
@mofojed mofojed requested review from a team and dgodinez-dh and removed request for a team October 14, 2025 19:30
@mofojed mofojed self-assigned this Oct 14, 2025
Copy link
Copy Markdown
Contributor

@dgodinez-dh dgodinez-dh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like TS is unhappy with the removal of type on some imports. But the removal looks intentional.

- I don't know how they got removed
@mofojed mofojed requested a review from dgodinez-dh October 15, 2025 20:34
@mofojed
Copy link
Copy Markdown
Member Author

mofojed commented Oct 15, 2025

I don't know how the type got removed on those imports, that was not intentional. Added them back.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.33%. Comparing base (c0084cf) to head (90f09d5).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/jsapi-utils/src/TableUtils.ts 75.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2550      +/-   ##
==========================================
+ Coverage   44.12%   44.33%   +0.21%     
==========================================
  Files         763      764       +1     
  Lines       42906    43050     +144     
  Branches    10827    10869      +42     
==========================================
+ Hits        18932    19087     +155     
+ Misses      23959    23947      -12     
- Partials       15       16       +1     
Flag Coverage Δ
unit 44.33% <75.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mofojed mofojed merged commit e9774ad into deephaven:main Oct 16, 2025
11 checks passed
@mofojed mofojed deleted the make-cancelable-event-promise-update branch October 16, 2025 12:56
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants