Skip to content

feat: DH-20769: Use new JS API in useViewportData to retrieve data #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericlln merged 25 commits into from
Oct 29, 2025
Merged

feat: DH-20769: Use new JS API in useViewportData to retrieve data #2557

Show file tree
Hide file tree
Changes from 21 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
7407a7d
use TableViewportSubscription in useViewportData
ericlln Oct 27, 2025
4f8577b
update jsapi-types
ericlln Oct 27, 2025
1bdfb7a
update root package-json and ran npm install
ericlln Oct 28, 2025
9e2ea71
avoid breaking change by providing default value
ericlln Oct 28, 2025
1901be9
remove unnecessary optional chaining
ericlln Oct 28, 2025
c089c56
avoid creating subscription in useEffect
ericlln Oct 28, 2025
6aa2394
add suggested test
ericlln Oct 28, 2025
57b390f
reorder check
ericlln Oct 28, 2025
0d26b09
add table null check and remove optional chaining
ericlln Oct 28, 2025
546f13c
move test constants outside tests
ericlln Oct 28, 2025
bc2a5bf
add test for testing if subscription was updated
ericlln Oct 28, 2025
68d1846
add test to check if subscription is closed on unmount
ericlln Oct 28, 2025
6559cef
add more defensive checks
ericlln Oct 28, 2025
07fa28a
remove unnecessary chaining
ericlln Oct 28, 2025
cd82f58
avoid cleaning up due to dependency change in useEffect
ericlln Oct 29, 2025
8aab5f4
update test with augmented version
ericlln Oct 29, 2025
e0407b3
Revert update to package-lock
ericlln Oct 29, 2025
50fe94b
Revert update to package-lock 2
ericlln Oct 29, 2025
cf12764
Update package-lock.json
ericlln Oct 29, 2025
ee19879
Revert "Update package-lock.json"
ericlln Oct 29, 2025
5b81381
update package-lock.json final
ericlln Oct 29, 2025
f3a7836
refactor cleanup step into function
ericlln Oct 29, 2025
ee168a4
ensure subscription was closed in test
ericlln Oct 29, 2025
37e932f
use a more clear formatting
ericlln Oct 29, 2025
026cb7d
simplify cleanup call
ericlln Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 20 additions & 19 deletions package-lock.json
View file
Open in desktop
Comment thread
bmingles marked this conversation as resolved.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@
"@deephaven/jsapi-components": "file:packages/jsapi-components",
"@deephaven/jsapi-nodejs": "file:packages/jsapi-nodejs",
"@deephaven/jsapi-shim": "file:packages/jsapi-shim",
"@deephaven/jsapi-types": "^1.0.0-dev0.37.2",
"@deephaven/jsapi-types": "^1.0.0-dev0.40.4",
"@deephaven/jsapi-utils": "file:packages/jsapi-utils",
"@deephaven/log": "file:packages/log",
"@deephaven/mocks": "file:packages/mocks",
Expand Down
2 changes: 1 addition & 1 deletion packages/app-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@deephaven/iris-grid": "file:../iris-grid",
"@deephaven/jsapi-bootstrap": "file:../jsapi-bootstrap",
"@deephaven/jsapi-components": "file:../jsapi-components",
"@deephaven/jsapi-types": "^1.0.0-dev0.39.4",
"@deephaven/jsapi-types": "^1.0.0-dev0.40.4",
"@deephaven/jsapi-utils": "file:../jsapi-utils",
"@deephaven/log": "file:../log",
"@deephaven/plugin": "file:../plugin",
Expand Down
2 changes: 1 addition & 1 deletion packages/auth-plugins/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@deephaven/components": "file:../components",
"@deephaven/jsapi-bootstrap": "file:../jsapi-bootstrap",
"@deephaven/jsapi-components": "file:../jsapi-components",
"@deephaven/jsapi-types": "^1.0.0-dev0.39.4",
"@deephaven/jsapi-types": "^1.0.0-dev0.40.4",
"@deephaven/jsapi-utils": "file:../jsapi-utils",
"@deephaven/log": "file:../log",
"@deephaven/redux": "file:../redux",
Expand Down
2 changes: 1 addition & 1 deletion packages/chart/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"dependencies": {
"@deephaven/components": "file:../components",
"@deephaven/icons": "file:../icons",
"@deephaven/jsapi-types": "^1.0.0-dev0.39.4",
"@deephaven/jsapi-types": "^1.0.0-dev0.40.4",
"@deephaven/jsapi-utils": "file:../jsapi-utils",
"@deephaven/log": "file:../log",
"@deephaven/react-hooks": "file:../react-hooks",
Expand Down
2 changes: 1 addition & 1 deletion packages/code-studio/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@deephaven/jsapi-bootstrap": "file:../jsapi-bootstrap",
"@deephaven/jsapi-components": "file:../jsapi-components",
"@deephaven/jsapi-shim": "file:../jsapi-shim",
"@deephaven/jsapi-types": "^1.0.0-dev0.39.4",
"@deephaven/jsapi-types": "^1.0.0-dev0.40.4",
"@deephaven/jsapi-utils": "file:../jsapi-utils",
"@deephaven/log": "file:../log",
"@deephaven/plugin": "file:../plugin",
Expand Down
2 changes: 1 addition & 1 deletion packages/console/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@deephaven/components": "file:../components",
"@deephaven/icons": "file:../icons",
"@deephaven/jsapi-bootstrap": "file:../jsapi-bootstrap",
"@deephaven/jsapi-types": "^1.0.0-dev0.39.4",
"@deephaven/jsapi-types": "^1.0.0-dev0.40.4",
"@deephaven/jsapi-utils": "file:../jsapi-utils",
"@deephaven/log": "file:../log",
"@deephaven/react-hooks": "file:../react-hooks",
Expand Down
2 changes: 1 addition & 1 deletion packages/dashboard-core-plugins/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@deephaven/iris-grid": "file:../iris-grid",
"@deephaven/jsapi-bootstrap": "file:../jsapi-bootstrap",
"@deephaven/jsapi-components": "file:../jsapi-components",
"@deephaven/jsapi-types": "^1.0.0-dev0.39.4",
"@deephaven/jsapi-types": "^1.0.0-dev0.40.4",
"@deephaven/jsapi-utils": "file:../jsapi-utils",
"@deephaven/log": "file:../log",
"@deephaven/plugin": "file:../plugin",
Expand Down
2 changes: 1 addition & 1 deletion packages/embed-widget/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@deephaven/dashboard-core-plugins": "file:../dashboard-core-plugins",
"@deephaven/jsapi-bootstrap": "file:../jsapi-bootstrap",
"@deephaven/jsapi-components": "file:../jsapi-components",
"@deephaven/jsapi-types": "^1.0.0-dev0.39.4",
"@deephaven/jsapi-types": "^1.0.0-dev0.40.4",
"@deephaven/jsapi-utils": "file:../jsapi-utils",
"@deephaven/log": "file:../log",
"@deephaven/plugin": "file:../plugin",
Expand Down
2 changes: 1 addition & 1 deletion packages/iris-grid/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@deephaven/grid": "file:../grid",
"@deephaven/icons": "file:../icons",
"@deephaven/jsapi-components": "file:../jsapi-components",
"@deephaven/jsapi-types": "^1.0.0-dev0.39.4",
"@deephaven/jsapi-types": "^1.0.0-dev0.40.4",
"@deephaven/jsapi-utils": "file:../jsapi-utils",
"@deephaven/log": "file:../log",
"@deephaven/react-hooks": "file:../react-hooks",
Expand Down
2 changes: 1 addition & 1 deletion packages/jsapi-bootstrap/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"dependencies": {
"@deephaven/components": "file:../components",
"@deephaven/jsapi-types": "^1.0.0-dev0.39.4",
"@deephaven/jsapi-types": "^1.0.0-dev0.40.4",
"@deephaven/log": "file:../log",
"@deephaven/react-hooks": "file:../react-hooks",
"@deephaven/utils": "file:../utils"
Expand Down
2 changes: 1 addition & 1 deletion packages/jsapi-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"dependencies": {
"@deephaven/components": "file:../components",
"@deephaven/jsapi-bootstrap": "file:../jsapi-bootstrap",
"@deephaven/jsapi-types": "^1.0.0-dev0.39.4",
"@deephaven/jsapi-types": "^1.0.0-dev0.40.4",
"@deephaven/jsapi-utils": "file:../jsapi-utils",
"@deephaven/log": "file:../log",
"@deephaven/react-hooks": "file:../react-hooks",
Expand Down
Loading
Loading
⚡