Skip to content

fix: readonly type changes #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mofojed merged 3 commits into from
Jan 27, 2026
Merged

fix: readonly type changes #2610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39c2aba
readonly type changes
ethanalvizo Jan 21, 2026
c1bb4c6
cast type
ethanalvizo Jan 22, 2026
dd1f38e
add ticket number
ethanalvizo Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/src/navigation/DashboardList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { GLOBAL_SHORTCUTS } from '../shortcuts';

export interface DashboardListProps {
onSelect: (tab: NavTabItem) => void;
tabs?: NavTabItem[];
tabs?: readonly NavTabItem[];
}

/**
Expand Down
10 changes: 6 additions & 4 deletions packages/jsapi-utils/src/TableUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1852,12 +1852,13 @@ export class TableUtils {
*/
async applyFilter<T extends DhType.Table | DhType.TreeTable>(
table: T | null | undefined,
filters: DhType.FilterCondition[],
filters: readonly DhType.FilterCondition[],
timeout = TableUtils.APPLY_TABLE_CHANGE_TIMEOUT_MS
): Promise<T | null> {
const { dh } = this;
return TableUtils.executeAndWaitForEvent(
t => t?.applyFilter(filters),
// TODO: #21450 Update JS API to accept readonly arrays
t => t?.applyFilter(filters as DhType.FilterCondition[]),
table,
dh.Table.EVENT_FILTERCHANGED,
timeout
Expand All @@ -1875,12 +1876,13 @@ export class TableUtils {
*/
async applySort<T extends DhType.Table | DhType.TreeTable>(
table: T | null | undefined,
sorts: DhType.Sort[],
sorts: readonly DhType.Sort[],
timeout = TableUtils.APPLY_TABLE_CHANGE_TIMEOUT_MS
): Promise<T | null> {
const { dh } = this;
return TableUtils.executeAndWaitForEvent(
t => t?.applySort(sorts),
// TODO: #21450 Update JS API to accept readonly arrays
t => t?.applySort(sorts as DhType.Sort[]),
table,
dh.Table.EVENT_SORTCHANGED,
timeout
Expand Down
Loading
⚡