Skip to content

fix: DH-21722: Fix Goto Value for Timestamps#2633

Merged
dgodinez-dh merged 12 commits intodeephaven:mainfrom
dgodinez-dh:dag_GotoTimestamp
Mar 17, 2026
Merged

fix: DH-21722: Fix Goto Value for Timestamps#2633
dgodinez-dh merged 12 commits intodeephaven:mainfrom
dgodinez-dh:dag_GotoTimestamp

Conversation

@dgodinez-dh
Copy link
Copy Markdown
Contributor

Fixes three issues with goto timestamp:

  • Right click menu option now populates with correctly formatted and working timestamp
  • Hot key goto now works
  • Paste unformatted timestamp now works

@dgodinez-dh dgodinez-dh requested a review from bmingles March 17, 2026 13:20
@dgodinez-dh dgodinez-dh changed the title fix: DH-21722: Fix Goto Value for Timestamps fix: DH-21722: Fix Goto Value for Timestamps Mar 17, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 78.04878% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.79%. Comparing base (6843d78) to head (5d69119).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/components/src/DateTimeInput.tsx 78.57% 3 Missing ⚠️
...d/src/mousehandlers/IrisGridContextMenuHandler.tsx 0.00% 3 Missing ⚠️
packages/iris-grid/src/IrisGrid.tsx 0.00% 2 Missing ⚠️
packages/components/src/MaskedInput.tsx 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2633      +/-   ##
==========================================
+ Coverage   49.51%   49.79%   +0.27%     
==========================================
  Files         774      774              
  Lines       43781    43808      +27     
  Branches    11263    11269       +6     
==========================================
+ Hits        21679    21815     +136     
+ Misses      22084    21947     -137     
- Partials       18       46      +28     
Flag Coverage Δ
unit 49.79% <78.04%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/components/src/DateTimeInput.test.tsx
Copy link
Copy Markdown
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Small suggestion on test simplification

@dgodinez-dh dgodinez-dh requested a review from bmingles March 17, 2026 15:08
Comment thread packages/components/src/DateTimeInput.test.tsx
Copy link
Copy Markdown
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgodinez-dh dgodinez-dh merged commit 70a3085 into deephaven:main Mar 17, 2026
11 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2026
@dgodinez-dh dgodinez-dh deleted the dag_GotoTimestamp branch March 17, 2026 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants