feat: DH-21947: Split out fetchVariableDefinitionByPredicate function#2634
Merged
bmingles merged 3 commits intodeephaven:mainfrom Mar 17, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2634 +/- ##
========================================
Coverage 49.79% 49.80%
========================================
Files 774 774
Lines 43808 43813 +5
Branches 11083 11271 +188
========================================
+ Hits 21815 21820 +5
+ Misses 21975 21947 -28
- Partials 18 46 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bmingles
requested review from
a team,
dgodinez-dh and
vbabich
and removed request for
a team and
vbabich
dgodinez-dh
reviewed
Mar 17, 2026
| "dev": true, | ||
| "hasInstallScript": true, | ||
| "license": "MIT", | ||
| "peer": true, |
Contributor
There was a problem hiding this comment.
Did you mean to check in a change to package-lock? I wonder if something has gotten out of sync.
Contributor
Author
There was a problem hiding this comment.
Yes. This seems to just be from someone not committing. I ensured I was on right node version and re-ran npm install. Resulted in same change
dgodinez-dh
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DH-21947: Split out fetchVariableDefinitionByPredicate function to support VS code extension