feat(plugin): add MultiPlugin type for registering multiple plugins from one module#2641
Merged
mofojed merged 2 commits intodeephaven:mainfrom Mar 25, 2026
Merged
Conversation
…rom one module - Add MULTI_PLUGIN to PluginType enum - Define MultiPlugin interface with plugins: Plugin[] property - Add isMultiPlugin() type guard - Update loadModulePlugins() to flatten MultiPlugin inner plugins - Update PluginsBootstrap to handle MultiPlugin in core plugins - Rename PluginModule to PluginModuleExport (with deprecated alias) - Add tests for MultiPlugin type guard and loading
dgodinez-dh
previously approved these changes
Mar 24, 2026
Contributor
dgodinez-dh
left a comment
There was a problem hiding this comment.
Looks like some checks are failing, but it doesn't look like anything major.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2641 +/- ##
==========================================
+ Coverage 49.51% 49.76% +0.24%
==========================================
Files 774 774
Lines 43781 43860 +79
Branches 11263 11291 +28
==========================================
+ Hits 21680 21828 +148
+ Misses 22055 21986 -69
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vbabich
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WidgetPluginand theDashboardPluginwere both registered